Skip to content

fix: ActionData type - disallow undefined, allow null#7962

Merged
dummdidumm merged 3 commits intomasterfrom
elliottjohnson-fix-actiondata-typing
Dec 7, 2022
Merged

fix: ActionData type - disallow undefined, allow null#7962
dummdidumm merged 3 commits intomasterfrom
elliottjohnson-fix-actiondata-typing

Conversation

@elliott-with-the-longest-name-on-github
Copy link
Contributor

@elliott-with-the-longest-name-on-github elliott-with-the-longest-name-on-github commented Dec 6, 2022 •
edited by dummdidumm
Loading

Closes #7961. Prior art: #6994.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Dec 6, 2022 •
edited
Loading

🦋 Changeset detected

Latest commit: 3351698

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Dec 6, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
kit ✅ Ready (Inspect) Visit Preview Dec 7, 2022 at 10:19AM (UTC)
kit-svelte-dev ✅ Ready (Inspect) Visit Preview Dec 7, 2022 at 10:19AM (UTC)

@dummdidumm
Copy link
Member

dummdidumm commented Dec 6, 2022

Thanks for pointing out the inconsistency about undefined/null - there was indeed one situation where undefined could sneak in, where it shouldn't.

@dummdidumm
Copy link
Member

dummdidumm commented Dec 6, 2022

almost forgot, this also needs a changeset

@dummdidumm dummdidumm merged commit 9d226d1 into master Dec 7, 2022
@dummdidumm dummdidumm deleted the elliottjohnson-fix-actiondata-typing branch December 7, 2022 10:17
@github-actions github-actions bot mentioned this pull request Dec 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dummdidumm dummdidumm dummdidumm approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ActionData is defined as inferred | undefined but can actually be inferred | undefined | null

2 participants

@elliott-with-the-longest-name-on-github @dummdidumm